Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify well known topic types for direct agent channel #4390

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Specify well known topic types for direct agent channel #4390

merged 3 commits into from
Nov 27, 2024

Conversation

jackgerrits
Copy link
Member

No description provided.

rysweet
rysweet approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@rysweet rysweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this assumes that RpcResponse is always a success type
we probably want a protbuf def then for ErrorResponse

@rysweet rysweet merged commit a6ccb6f into main Nov 27, 2024
43 checks passed
@rysweet rysweet deleted the well_known_topics branch November 27, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rysweet rysweet rysweet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackgerrits @rysweet